This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
Fix typo in issue number, and add issue number #1497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
commented
Jul 17, 2018
| @@ -57,12 +57,13 @@ | |||
| produced accidentally created two queries instead of one. | |||
| [Closes #1455][#1455]. | |||
There was a problem hiding this comment.
@alorenzen: in general when referring to an issue number, how about simply writing the issue number in parentheses at the end of the bullet rather than Closes #1234? It would be more concise and amount to less typing.
There was a problem hiding this comment.
I'll merge this as is, but I'm personally for adopting this suggestion if we agree on it. @alorenzen @matanlurey
Closed
matanlurey
pushed a commit
that referenced
this pull request
Jul 18, 2018
Closes #1497 PiperOrigin-RevId: 205120205
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1849-> AddcastCallback1->Ntopackage:angular/meta.dart#1489cc @kwalrath