Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitParser: fix the nullability of the Parse / TryParse overloads #1445

Open
lipchev opened this issue Dec 9, 2024 · 2 comments
Open

UnitParser: fix the nullability of the Parse / TryParse overloads #1445

lipchev opened this issue Dec 9, 2024 · 2 comments

Comments

@lipchev
Copy link
Collaborator

lipchev commented Dec 9, 2024

Can we add this to #1200

@lipchev
Copy link
Collaborator Author

lipchev commented Dec 9, 2024

Oh I just realized this also the case for the static method on the quantities (e.g. Mass.TryParseUnit(..)):

@angularsen angularsen mentioned this issue Dec 9, 2024
14 tasks
@angularsen
Copy link
Owner

Added it

@lipchev lipchev changed the title UnitConverer: fix the nullability of the Parse / TryParse overloads UnitParser: fix the nullability of the Parse / TryParse overloads Dec 10, 2024
angularsen added a commit that referenced this issue Dec 15, 2024
(UnitParser, QuantityParser, Quantity)

fixes #1445

---------

Co-authored-by: Andreas Gullberg Larsen <andreas.larsen84@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants