Implementing IConvertible #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angularsen
requested changes
Feb 1, 2019
...t.WindowsRuntimeComponent/GeneratedCode/Quantities/Acceleration.WindowsRuntimeComponent.g.cs
Outdated
Show resolved
Hide resolved
|
Ok, this is kinda neat! A bit unsure about converting to numbers like this, but hey, I guess it's the caller's funeral if they convert to number type and expected a different value :-) Is there any good way to communicate what to expect here? I don't see where to put that xmldoc though. Remarks on the class maybe? |
|
Exactly. I think it implementing IConvertible should be enough really, but we can add a remark. I guess I could add inheritdoc on each of the methods too. |
|
I can actually see the doc even without inheritdoc. I guess because the LHS is IConvertible when you do so anyways, it gets it from there. |
|
Ok nice, there's a merge conflict here, but other than that you can just merge it. |
angularsen
approved these changes
Feb 1, 2019
|
Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.