Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libexpory-1.5 fails to build with uclibc #181

Closed
stefson opened this issue Jun 18, 2018 · 3 comments
Closed

libexpory-1.5 fails to build with uclibc #181

stefson opened this issue Jun 18, 2018 · 3 comments

Comments

@stefson
Copy link

stefson commented Jun 18, 2018

when compiling libpoxy-1.5 with uclibc, the build breaks with this error:

../libepoxy-1.5.2/test/egl_has_extension_nocontext.c:58:24: error: implicit declaration of function 'strdup' [-Werror=implicit-function-declaration]
         an_extension = strdup(extensions);
                        ^~~~~~
../libepoxy-1.5.2/test/egl_has_extension_nocontext.c:58:24: warning: incompatible implicit declaration of built-in function 'strdup'

I added the build log and a log with the most important os libs and compilers.

full build log
emerge --info

libepoxy 1.4 is just fine by the way

@ebassi
Copy link
Collaborator

ebassi commented Jun 18, 2018

egl_has_extension_nocontext.c had that strdup() call since commit 0270c80 in 2013, i.e. since 1.4.0, and uclibc has a strdup() implementation – though it seems it's gated on _XOPEN_SOURCE_EXTENDED.

ebassi added a commit that referenced this issue Jun 18, 2018
The strdup() function is available on uClibc if _XOPEN_SOURCE_EXTENDED
is defined; since we're using _GNU_SOURCE elsewhere to enable extended
libc features, and uClibc will set _XOPEN_SOURCE_EXTENDED if _GNU_SOURCE
is set, let's use that.

Closes #181
@ebassi
Copy link
Collaborator

ebassi commented Jun 18, 2018

@stefson could you try building #182?

@stefson
Copy link
Author

stefson commented Jun 18, 2018

yes, it does build now! thanks for the fast fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants