meson: Set same variables in declare_dependency() as in pkgconfig #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebassi
reviewed
Oct 14, 2020
gnomesysadmins
pushed a commit
to GNOME/gtk
that referenced
this pull request
Oct 15, 2020
epoxy_dep cannot be used in a configure time check when it comes from a subproject. Use variables set in pc file instead. This requires anholt/libepoxy#231.
gnomesysadmins
pushed a commit
to GNOME/gtk
that referenced
this pull request
Oct 15, 2020
epoxy_dep cannot be used in a configure time check when it comes from a subproject. Use variables set in pc file instead. This requires anholt/libepoxy#231.
|
@ebassi need to update Meson version in CI, do you know how? |
|
@xclaesse I'll have to update the Docker image we use on Travis. |
|
FYI, I fixed the inconsistency in meson: mesonbuild/meson#7853. |
|
We don't use Travis any more, so no more Docker images. Care to rebase on |
GTK currently fails to detect if epoxy has been built with EGL on Windows when epoxy is a subproject. To fix that it needs to get that information from the dependency variables. This requires Meson >=0.54.0 for setting variables in declare_dependency().
|
I miss gitlab's rebase button. Done manually :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTK currently fails to detect if epoxy has been built with EGL on
Windows when epoxy is a subproject. To fix that it needs to get that
information from the dependency variables.