dispatch: fix loading of GL without GLX library #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading the GL library in `epoxy_load_gl`, we in turn try to load OPENGL_LIB and GLX_LIB. But notably, we'll also try to load GLX_LIB even if loading OPENGL_LIB succeeded. As this load will abort in case the library wasn't found, the end result is that systems without GLX_LIB will always fail `epoxy_load_gl`. Fix the issue by only trying to load GLX_LIB in case OPENGL_LIB wasn't found.
|
@anholt can you comment if this is a viable fix? Several distro maintainers are unsure how to proceed with glvnd so we need some expertise. |
|
This should have been fixed in #257. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading the GL library in
epoxy_load_gl, we in turn try to loadOPENGL_LIB and GLX_LIB. But notably, we'll also try to load GLX_LIB even
if loading OPENGL_LIB succeeded. As this load will abort in case the
library wasn't found, the end result is that systems without GLX_LIB
will always fail
epoxy_load_gl.Fix the issue by only trying to load GLX_LIB in case OPENGL_LIB wasn't
found.