Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msvc-env.yml #291

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update msvc-env.yml #291

wants to merge 4 commits into from

Conversation

mosfet80
Copy link

updated BSFishy/meson-build

updated BSFishy/meson-build
@ebassi
Copy link
Collaborator

ebassi commented Sep 25, 2023

It usually helps to specify why you need to change something. In this particular case: why is it necessary to update the version of the action?

the libraries currently used allow the use of Python v 3.5 (eol 2020), which is not safe to use.


meson build to 1.0.3
update to setup-python@v4 
meson-version to 1.2.2
@mosfet80
Copy link
Author

mosfet80 commented Oct 4, 2023

The libraries currently used allow the use of Python v 3.5 (eol 2020), which is not safe to use.

meson build to 1.0.3
update to setup-python@v4
meson-version to 1.2.2

now minimum requirements are:

[Python] version 3.7 or newer
[Ninja] version 1.8.2 or newer

@ebassi
Copy link
Collaborator

ebassi commented Oct 4, 2023

Perfect, thank you for the explanation.

removed argument --fatal-meson-warnings
updated meson version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants