Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type declarations #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add type declarations #16

wants to merge 1 commit into from

Conversation

Juhan280
Copy link

@Juhan280 Juhan280 commented Mar 7, 2023 •
edited
Loading

Changes

This pr adds the type declarations for the minigame classes

Resolves #15

Screenshots

N/A

Status

  • These changes have been tested and formatted properly.
  • These changes also include the change in documentation accordingly.
  • This PR introduces some Breaking changes

@Juhan280
Copy link
Author

I think I have added them all. Anyone willing to test it?

npm i Juhan280/Gamecord

@Juhan280 Juhan280 mentioned this pull request Mar 14, 2023
Open
@Juhan280 Juhan280 marked this pull request as ready for review March 24, 2023 10:23
ChrisSch-dev

This comment was marked as duplicate.

Sign in to view

PdroCorrea
PdroCorrea approved these changes Jul 31, 2023
View reviewed changes
Copy link

@PdroCorrea PdroCorrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Juhan280 Juhan280 mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSch-dev ChrisSch-dev ChrisSch-dev approved these changes

@PdroCorrea PdroCorrea PdroCorrea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add Types
3 participants
@Juhan280 @PdroCorrea @ChrisSch-dev