Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a description to wordle embed #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ItsFranklinMyDudes
Copy link

Changes

added a new option, description to the embed as ive seen so many people wonder how to play

Screenshots

Screenshot on gameplay with change

Status

  • These changes have been tested and formatted properly.
  • These changes also include the change in documentation accordingly.
  • This PR introduces some Breaking changes

@ChrisSch-dev
Copy link

Remove the catch block in line 150 and 151

This is an npm package, api errors such as that of those 2 lines should be left to the developers themselves to handle.

Adding a catch block to those 2 lines also eliminates the option for developers to debug stuff when the bot doesn’t reply/edit the message but no error is logged into the console, which can cause confusion.

Copy link

@ChrisSch-dev ChrisSch-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 150 and 151 remove catch block

@retrouser955
Copy link

retrouser955 commented Oct 4, 2024

Seems Aniket also does these. May I suggest handling these more elegantly via an onError callback or a listener. If the listener does not exist, the program will throw and if it does, the error will me emitted. This helps developers handle the error in their own way.

@ItsFranklinMyDudes
Copy link
Author

Line 150 and 151 remove catch block

i did not add that catch, all i did was the description thing, literally have no idea where that came from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants