Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bankers Divide #8

Closed
anilhelvaci opened this issue May 20, 2022 · 1 comment
Closed

Bankers Divide #8

anilhelvaci opened this issue May 20, 2022 · 1 comment
Assignees
@anilhelvaci
Labels
Migration Related to upgrading to the newer versions of sdk

Comments

@anilhelvaci
Copy link
Owner

In the 0.15 version of the sdk the method quantize uses bankersDivide method instead of ceilDivide which causes some changes in the calculation of the interest rates. Either update lending protocol's calculations to this or implement something to keep using ceilDivide
@anilhelvaci anilhelvaci added the Migration Related to upgrading to the newer versions of sdk label May 20, 2022
@anilhelvaci anilhelvaci self-assigned this May 20, 2022
anilhelvaci added a commit that referenced this issue May 22, 2022
@anilhelvaci
#8 Test numbers adopted banker's divide
02b237c
anilhelvaci added a commit that referenced this issue May 25, 2022
@anilhelvaci
#3 Base case for redeeming funds implemented, #8 Exchange rate is now…
455a3b7 
… stored in the LARGE_DENOMINATOR basis instead of BASIS_POINTS in order to adopt the banker's rounding in a healthier manner.
@anilhelvaci
Copy link
Owner Author

In beta branch of agoric-sdk quantize method used ceilDivide but in the master it uses bankersDivide, our protocol is now on beta branch but we implemented bankersDivide for math sheet as well. When we update our protocol to master branch we might need to re-open this issue but for now I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anilhelvaci anilhelvaci

Labels
Migration Related to upgrading to the newer versions of sdk
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anilhelvaci