Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #5

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Minor fixes #5

merged 1 commit into from
Mar 18, 2020

Conversation

elizabetdev
Copy link

@elizabetdev elizabetdev commented Mar 18, 2020

I just changed a few things:

  • The CSS classes should respect the BEM naming convention. Both euiCodeBlock__pre--whiteSpacePre and euiCodeBlock__pre--whiteSpacePreWrap are modifiers. You an find more info about BEM here
  • I also changed the description text and added some code highlights

@anishagg17 anishagg17 merged commit a5c4cca into anishagg17:wrap Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants