Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing return statements #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mirjalal
Copy link
Contributor

return statements added to fire callback(s) on time.

I tested on my device (LG G4 running w/ Android 6.0 has no any biometric auth related software & hardware component) & as a result without the return statements exception thrown.

`return` statements added to fire callback(s) on time. 

I tested on my device (LG G4 running w/ Android 6.0 has no any biometric auth related software & hardware component) & as a result without the `return` statements exception thrown.
@Sammekl
Copy link

Sammekl commented Apr 29, 2019

This PR is not necessary when #9 gets merged, which I prefer due to additional functionality

@mirjalal
Copy link
Contributor Author

mirjalal commented Apr 30, 2019

@Sammekl PR #9 was opened after this PR (#8) created. Also, PR #9 is based on this comment which I made it before #9 was opened. Thus, there is a small conflict and similarity between #8 and #9. Of course, it is all up to you ;)

Cheers!

Copy link

@Sammekl Sammekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As #9 has been successfully merged, this is no longer necessary. Thanks for the PR though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants