Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design UI for email confirmation #869

Closed
wants to merge 1 commit into from

Conversation

SHITIZ-AGGARWAL
Copy link
Contributor

@SHITIZ-AGGARWAL SHITIZ-AGGARWAL commented Sep 15, 2020

Description

providing design for email verification

Fixes #768

Type of Change:

  • User Interface

figma link : https://www.figma.com/file/wQp9Gj2QTaTlMs7nGi5aFo/email-verification?node-id=0%3A1

image

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #869 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #869   +/-   ##
========================================
  Coverage    95.84%   95.84%           
========================================
  Files           95       95           
  Lines         5199     5199           
========================================
  Hits          4983     4983           
  Misses         216      216           

@SHITIZ-AGGARWAL
Copy link
Contributor Author

@SanketDG @gaurivn I created a new pull request with the following changes ,please suggest if any changes required : )

Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

I personally would like if figma links just exists in issues, and then they are coded and a PR is created. There can always be a new issue that can be created to code this UI.

Also, why not just do a white background?

@SHITIZ-AGGARWAL
Copy link
Contributor Author

SHITIZ-AGGARWAL commented Sep 15, 2020

@SanketDG I changed the background to white please tell if it is okay so that I can change the description image

@SanketDG
Copy link
Contributor

Looks good @SHITIZ-AGGARWAL

@SHITIZ-AGGARWAL
Copy link
Contributor Author

SHITIZ-AGGARWAL commented Sep 25, 2020

@SanketDG is this PR ready for OSH submission

@SanketDG
Copy link
Contributor

Sure, I am not sure whether @isabelcosta will merge this in, because this is clearly very temporary work.

Asking @gaurivn to create an issue for the implementation so that someone code this.

Can you also paste the screenshots/UI links in the issue? @SHITIZ-AGGARWAL

@SHITIZ-AGGARWAL
Copy link
Contributor Author

@SanketDG sure

@gaurivn gaurivn requested a review from isabelcosta September 28, 2020 20:54
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vj-codes please add a label

@vj-codes
Copy link
Member

vj-codes commented Nov 3, 2020

@devkapilbansal which label do you want ?
I doubt this PR's merging status as this and other UI PRs are just a mockups . However will double check with other project managers and Isabel :)

@devkapilbansal
Copy link
Member

devkapilbansal commented Nov 3, 2020

@vj-codes if this PR will be merged then Ready to Merge label or if we need review from maintainers then Review Required label. But, we should add a label to the PR to categorise it

@devkapilbansal
Copy link
Member

@isabelcosta needs your input here

@isabelcosta
Copy link
Member

Thank you @devkapilbansal for pinging me here 🙌🏾
@SHITIZ-AGGARWAL thank you for contributing for OSH!
We will close the issue as we're going discuss designs with new community design ambassadors. I will add this PR to our Wiki :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design UI for email confirmation
5 participants