-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design UI for email confirmation #869
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #869 +/- ##
========================================
Coverage 95.84% 95.84%
========================================
Files 95 95
Lines 5199 5199
========================================
Hits 4983 4983
Misses 216 216 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
I personally would like if figma links just exists in issues, and then they are coded and a PR is created. There can always be a new issue that can be created to code this UI.
Also, why not just do a white background?
@SanketDG I changed the background to white please tell if it is okay so that I can change the description image |
Looks good @SHITIZ-AGGARWAL |
@SanketDG is this PR ready for OSH submission |
Sure, I am not sure whether @isabelcosta will merge this in, because this is clearly very temporary work. Asking @gaurivn to create an issue for the implementation so that someone code this. Can you also paste the screenshots/UI links in the issue? @SHITIZ-AGGARWAL |
@SanketDG sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@vj-codes please add a label
@devkapilbansal which label do you want ? |
@vj-codes if this PR will be merged then |
@isabelcosta needs your input here |
Thank you @devkapilbansal for pinging me here 🙌🏾 |
Description
providing design for email verification
Fixes #768
Type of Change:
figma link : https://www.figma.com/file/wQp9Gj2QTaTlMs7nGi5aFo/email-verification?node-id=0%3A1
Checklist: