-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create UI_for_relation_request_email.md #873
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #873 +/- ##
========================================
Coverage 95.99% 95.99%
========================================
Files 96 96
Lines 5287 5287
========================================
Hits 5075 5075
Misses 212 212 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note sent by the mentee in this case is only Hi and export the figma design to png and place just the screenshot here instead of the figma link. And the "Take Action" button is not necessarily needed. Just button for "Login" would do so the mentor can see the notification and act accordingly.
Okay i'll make the necessary changes. Do i have to upload the png separately or in the md file itself ? |
Mock-up for the UI pf relation request email
@gaurivn Pls see if it's correct now and guide me... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you, I'll ask @isabelcosta for review/ more insight.
@titiksha01 thank you for contributing for OSH! |
Description
Added a mock so that i can get the reviews and proceed to code.
Fixes #770
Type of Change:
Mock
Checklist: