This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All selenium tests have been restructured to share code in this PR. Functions which could be possibly reused have been identified and created for the tests. In most tests, constants have also been isolated at the top so that any change in UI only requires a change at the beginning of the file.
There is reduction in both test times and lines as follows -
Time (approx. ) - 74 min to 44 min (around 41-42% reduction)
Lines reduced due to removal of duplication and unnecessary imports in tests files - approx 30% (7527 to 5300)
Travis build timings also have similar reduction ( from approx. 16 to 9 min ~ 43%)
Number of tests have also increased from 164 to 168 but these are not new tests. I have broken subparts of a few tests into separate ones as they were repeatedly testing the same thing
Related to #369