Add support for different prediction types #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunosilva800
commented
Dec 12, 2024
Comment on lines
+151
to
+155
| # @param predict_type [Integer] What should be predicted | ||
| # - C_API_PREDICT_NORMAL: normal prediction, with transform (if needed); | ||
| # - C_API_PREDICT_RAW_SCORE: raw score; | ||
| # - C_API_PREDICT_LEAF_INDEX: leaf index; | ||
| # - C_API_PREDICT_CONTRIB: feature contributions (SHAP values) |
There was a problem hiding this comment.
Using a single argument instead of 3 boolean args, like Python API does.
https://lightgbm.readthedocs.io/en/stable/pythonapi/lightgbm.Booster.html#lightgbm.Booster.predict
@ankane
Let me know which you prefer. I don't really see the point of 3 booleans, since they are exclusive...
nunosilva800
commented
Dec 12, 2024
| assert_elements_in_delta [ | ||
| 0.1094902954684793, -0.2810485083947154, 0.26691627597706397, -0.13037702397316747 | ||
| ], shap_values_2 | ||
| assert_in_delta (0.9933333333834246), ypred_2 |
There was a problem hiding this comment.
I don't understand why the last value (supposed to be the prediction result) is the same on each row, and why different from expected ypred values in other tests.
|
Thanks @nunosilva800, merged a version of this in the commit above. I'd prefer to keep the API consistent with Python. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for different prediction types.
C API: https://lightgbm.readthedocs.io/en/stable/C-API.html#c.LGBM_BoosterPredictForMat
Python API: https://lightgbm.readthedocs.io/en/stable/pythonapi/lightgbm.Booster.html#lightgbm.Booster.predict