Sort features when receiving input as hash #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunosilva800
commented
Oct 18, 2024
| @@ -241,6 +245,11 @@ def read_int64(ptr) | |||
| ptr.read_array_of_int64(1).first | |||
| end | |||
|
|
|||
| def sorted_feature_values(input_hash) | |||
| @cached_feature_names ||= feature_name | |||
| input_hash.transform_keys(&:to_s).fetch_values(*@cached_feature_names) | |||
There was a problem hiding this comment.
I'm considering if accepting the input hash with keys as symbol or string is worth it, or if it should expect only strings.
Quick benchmark (10000 iterations):
user system total real
keys are strings: 0.031401 0.001063 0.032464 ( 0.032646)
with transform_keys: 0.108264 0.005040 0.113304 ( 0.113892)
Suggested change
| input_hash.transform_keys(&:to_s).fetch_values(*@cached_feature_names) | |
| input_hash.fetch_values(*@cached_feature_names) |
|
Thanks @nunosilva800! I think it should support both symbols and strings (it could check the first row to see which is used and take different paths, but think it's probably not worth the complexity). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the popular usage of hashes in Ruby, I think this would be a nice quality of life addition to the Booster#predict API.