Do not reindex type automatically. #1643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a partial reindex (to index a new field, for example), searchkick was reindexing `type` even when not asked to. This is a problem because maybe you want to reindex `type` with a different value, and after doing a partial index, you need to call the `reindex` again by type — mainly because searchkick has overridden the type using the `document_type` method. Performance is a concern here. Imagine doing that for millions of rows; it will take more time to finish the reindexing.
|
@ankane can we get a review here? |
|
@ankane :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a partial reindex (to index a new field, for example), searchkick was reindexing
typeeven when not asked to.This is a problem because maybe you want to reindex
typewith a different value, and after doing a partial index, you need to call thereindexagain by type — mainly because searchkick has overridden the type using thedocument_typemethod.Performance is also a concern here.