Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor dev suggestion: don't turn Kotlin warnings into errors except in CI #11660

Closed
dae opened this issue Jun 19, 2022 · 4 comments
Closed

Minor dev suggestion: don't turn Kotlin warnings into errors except in CI #11660

dae opened this issue Jun 19, 2022 · 4 comments

Comments

@dae
Copy link
Contributor

dae commented Jun 19, 2022

Making things like unused variables hard errors makes it more cumbersome to comment out a section of code while testing.

@mikehardy
Copy link
Member

I see what you're saying, but in our experience twice now with the GSoC avalanche, getting errors prior to CI is a big win for us, we push hard for detection of all things that would fail CI to fail immediately on a dev workstation and only through the accumulation of a lot of marginal gains like that are we able to survive March/April/May as maintainers

Is there some more trivial local hack you can do to swap out the rules list?

@dae
Copy link
Contributor Author

dae commented Jun 20, 2022

Gotcha, I'll do that then.

@dae dae closed this as completed Jun 20, 2022
@dae
Copy link
Contributor Author

dae commented Jun 20, 2022

Implemented in ecdf4ad in #11644

@mikehardy
Copy link
Member

That's a good tradeoff - I like that, local failures pre-CI has been a big help but an override for those that can handle a foot-gun works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants