Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed NPE during sync #11904

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

thedroiddiv
Copy link
Member

@thedroiddiv thedroiddiv commented Jul 22, 2022

Purpose / Description

Bug fix- Sync fail due to NPE. I think this bug was introduced as a result of Kotlin Migration #11864 of Syncer.java and wasn't picked up by test.

Fixes

May be a part of #11891, not sure.

Approach

Instead of retuning null from useLim return an empty array.

How Has This Been Tested?

Unit tested and on Realme 6i API 30

Learning

After any change, make sure to test on real-device from your own side. Automated tests are not always enough. 🥲

Checklist

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner
sync.mp4

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I was looking at this myself 😄

@lukstbit lukstbit added the Needs Second Approval Has one approval, one more approval to merge label Jul 22, 2022
@david-allison david-allison merged commit 025f70a into ankidroid:main Jul 22, 2022
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Jul 22, 2022
@github-actions github-actions bot added this to the 2.16 release milestone Jul 22, 2022
@thedroiddiv thedroiddiv deleted the sync_error_fix branch July 22, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants