-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove redundant '@JvmStatic' annotations #12317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukstbit
requested changes
Sep 5, 2022
AnkiDroid/src/test/java/com/ichi2/anki/servicemodel/UpgradeGesturesToControlsTest.kt
Outdated
Show resolved
Hide resolved
lukstbit
added
Needs Author Reply
Waiting for a reply from the original author
Needs Review
labels
Sep 5, 2022
david-allison
removed
the
Needs Author Reply
Waiting for a reply from the original author
label
Sep 5, 2022
david-allison
force-pushed
the
remove-JvmStatic
branch
from
September 5, 2022 11:41
58c8de4
to
3d93b2e
Compare
We're no longer in Java, so only a few annotations are still necessary. These are mostly test methods (`@Parameters/@MethodSource`), a few which are useful for mocks, and a small number which cause tests to fail if they're removed for no reasonable reason This is a potentially flaky commit, hopefully the reduction in code causes a reduction in compile times This was a mostly automated process, adding comments manually if removing the annotation failed tests It did not modify the API project public classes
david-allison
force-pushed
the
remove-JvmStatic
branch
from
September 5, 2022 11:42
3d93b2e
to
7743600
Compare
lukstbit
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lukstbit
added
Needs Second Approval
Has one approval, one more approval to merge
and removed
Needs Review
labels
Sep 5, 2022
mikehardy
reviewed
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AnkiStatsTaskHandlerTest > testCreateReviewSummaryStatistics FAILED
kotlinx.coroutines.test.UncompletedCoroutinesError: After waiting for 60000 ms, the test coroutine is not completing
at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$3$3.invokeSuspend(TestBuilders.kt:342)
(Coroutine boundary)
at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTestCoroutine(TestBuilders.kt:326)
at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invokeSuspend(TestBuilders.kt:167)
at kotlinx.coroutines.test.TestBuildersJvmKt$createTestResult$1.invokeSuspend(TestBuildersJvm.kt:13)
Caused by:
kotlinx.coroutines.test.UncompletedCoroutinesError: After waiting for 60000 ms, the test coroutine is not completing
at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$3$3.invokeSuspend(TestBuilders.kt:342)
at app//kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:284)
at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
at kotlinx.coroutines.test.TestBuildersJvmKt.createTestResult(TestBuildersJvm.kt:12)
at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest(TestBuilders.kt:166)
at kotlinx.coroutines.test.TestBuildersKt.runTest(Unknown Source)
at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest(TestBuilders.kt:154)
at kotlinx.coroutines.test.TestBuildersKt.runTest(Unknown Source)
🤔 ?
(locally - target testPlayDebugUnitTest
)
Flaky (with a potentially pending fix): #11091 (comment) |
mikehardy
approved these changes
Sep 6, 2022
github-actions
bot
removed
the
Needs Second Approval
Has one approval, one more approval to merge
label
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're no longer in Java, so only a few annotations are still necessary.
These are mostly test methods (
@Parameters/@MethodSource
), a few which are useful for mocks, and a small number which cause tests to fail if they're removed for no reasonable reasonThis is a potentially flaky commit, hopefully the reduction in code causes a reduction in compile times which makes this worthwhile
This was a mostly automated process, adding comments manually if removing the annotation failed tests
It did not modify the API project public classes
Checklist