non-functional: sync Decks
with libAnki
#15813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Decks
was pretty badly out of sync withdecks.py
https://github.com/ankitects/anki/blob/main/pylib/anki/decks.py
I want to get back in sync, as #15611 has shown that we still have issues.
This will also allow us to more easily deprecate the
legacy
methods, rather than using a combination of new and legacy methodsAs a long-term stretch goal, this brings us closer to automation to map from
libanki
topylib
Approach
LibAnkiAlias
: I suspect we'll eventually want all methods inlibAnki
to be annotated by this ORNotinLibAnki
. This makes it easier to map fromlibanki
topylib
How Has This Been Tested?
Ran unit tests, then rebased onto
main
Checklist