Block reports sent to ACRA

[voczi]

See title. Related:
#17392
ankidroid/Anki-Android-Backend#439
ankitects/anki@ba1f5f4

Preemptive "may lord have mercy".

[mikehardy]

general idea looks good and implementation seems functional (though I have poor Kotlin taste still, so don't rely on that)
some comments on functional/non-functional mix in the comment but I was able to parse through
bit o bike-shedding on throwable vs exception in naming etc

[david-allison]

Architecture:

• This doesn't process logcat
• I believe this changes the type of the exception to Throwable

[mikehardy]

with regard to "This doesn't process logcat" from David -> I noticed while verifying my acrarium purge that there were some instances where the stack prompting a current error did not contain an email but the included logcat did. So it is a valid concern. I altered my purge matcher to also match emails deeper into the report (logcat also, not just original stack) so I'm cleaning them now, but better if they never hit logcat. Whole thing is messy, for sure

[voczi]

Work's left to be done. Still unsure about certain things.

[david-allison]

Looks SO much better, thanks so much!!!

One suggestion, take it or leave it

[david-allison]

Approval still stands.

Important

squash-merge The pull request currently requires maintainers to "Squash Merge"

Given discussion on Discord - pushing this back to also be implemented for unhandled exceptions

[mikehardy]

To be concrete about the idea of installing the filter as an uncaught exception handler also, here is exactly how to do it

Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/analytics/UsageAnalytics.kt

Lines 117 to 131 in 15b748a

	/**
	* We want to send an analytics hit on any exception, then chain to other handlers (e.g., ACRA)
	*/
	@Synchronized
	private fun installDefaultExceptionHandler() {
	sOriginalUncaughtExceptionHandler = Thread.getDefaultUncaughtExceptionHandler()
	Thread.setDefaultUncaughtExceptionHandler { thread: Thread?, throwable: Throwable ->
	sendAnalyticsException(throwable, true)
	if (thread == null) {
	Timber.w("unexpected: thread was null")
	return@setDefaultUncaughtExceptionHandler
	}
	sOriginalUncaughtExceptionHandler!!.uncaughtException(thread, throwable)
	}
	}

As long as we already have the filter logic, it's just "store ref to original handler, install ourselves as handler, and after we handle an uncaught exception pass it on to the original handler" - idea being that this is yet another ask on the PR but this one is hopefully satisfyingly easy and then covers the last place these could slip through