Introduce enums in Dialog #17432
Open
Introduce enums in Dialog #17432
+194
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an enum and constants
david-allison
requested changes
Nov 13, 2024
Comment on lines
+35
to
+37
| companion object { | ||
| fun Int.toType() = Type.entries[this] | ||
| } |
There was a problem hiding this comment.
as in other PRs, be explicit
There was a problem hiding this comment.
I'm sorry, I'm not sure what you want here.
That the name is ImportDialogType instead of ImportDialog.Type ?
That the toType is documented?
Comment on lines
+262
to
+263
| companion object { | ||
| fun Int.toType() = Type.entries[this] |
david-allison
added
the
Needs Author Reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve typing