Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn updates - all deps + move to modern yarn #17535

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

mikehardy
Copy link
Member

@mikehardy mikehardy commented Dec 2, 2024

Not sure anyone else is qualified here to do yarn maintenance work and eventually has to get done, so here it is

we were using yarn v1 and they are on v4+ now, so let's adopt the new style...

if it works in CI it'll work

the major change in the new style is that you can use "plug-n-play" (read as: no node_modules folder) if you like and it's way faster, but is also not backwards compatible. But you don't have to. And the backwards-compatible "don't have to think about it" way to migrate is just to keep the linker-style as node_modules, so we do that here

In that sense - it is a major but also very easy upgrade. I've done it in lots of repos now without issue

https://yarnpkg.com/migration/guide

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks fine.

This doesn't appear to include the version bump in the linked/closed PR

@mikehardy
Copy link
Member Author

This doesn't appear to include the version bump in the linked/closed PR

it was a transitive buried deeply, and was handled in the dependency-updates dependabot PR that bumped the slightly-less transitive eslint stuff more than a week ago ?

c5899d9#diff-169dd946d44a1ed2c7bcffbc9822c0ef43c76595b053bc88a577c12b5ec77c2eL359

This is an artifact of dependabot posting security updates to main, and regular stuff to dependency-updates. It's not great

@mikehardy mikehardy merged commit f2ad6c5 into ankidroid:dependency-updates Dec 2, 2024
12 checks passed
@mikehardy mikehardy deleted the yarn-updates branch December 2, 2024 19:38
@github-actions github-actions bot added this to the 2.20 Release milestone Dec 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Hi there @mikehardy! This is the OpenCollective Notice for PRs merged from 2024-12-01 through 2024-12-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

Important

PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies used for automated dependency PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants