fix: "Reviewing" & Deck import do not handle SchedV1 correctly

[oyeraghib]

Purpose / Description

"Reviewing" & Deck import do not handle SchedV1 correctly

Fixes

• Fixes Settings - "Reviewing" & Deck import do not handle SchedV1 correctly #17838

Approach

created a function to handle the update of SchedV1 inside Reviewing in Preferences Settings

How Has This Been Tested?

Physical device : Manually tested on Pixel 6a - Android 15

Before

screen-20250130-023513-2.mp4

After

screen-20250130-022757-2.mp4

Learning (optional, can help others)

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[BrayanDSO]

Could you do the check in the reviewing fragment itself? This looks messy

[oyeraghib]

@BrayanDSO That could be done. But isn't this should be the ideal behaviour that "ReviewFragment" is not opened if the SchedV1 is not updated. If this is put in ReviewFragment, that would open the fragment even though nothing would be functional until Sched is updated.

[oyeraghib]

Updated. It definitely looks much cleaner.

[BrayanDSO]

Since nothing should work on a V1 collection, I think that the dialog should be shown when entering the app (maybe in the database error dialog) and shouldn't be dismissible.

That way we won't have the issue again in the future because we missed a screen, or because something new doesn't work on sched v1.

It also should be simpler to code.

[oyeraghib]

@BrayanDSO I tried implementing that and it works fine. But the problem is in one of the case -> When the app has already opened the app and imports a v1 collection then in that case there won't be any checks that time as the app wasn't started so no dismissible dialog will be shown and we will have to handle it like this only.

Let me know what you think here.