refactor: use state flow for did in InstantEditor

[criticalAY]

Purpose / Description

Resolves a TODO and uses state flow for deck id in Instant Editor

Approach

Use stateFlow()

How Has This Been Tested?

POCO API 33

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[lukstbit]

This and the other coroutine in this file is incorrect both in how the code behaves and the purpose.

How the code behaves: This creates a coroutine on the ViewModel's own scope with a lambda declared here which will capture the activity and potentially leak it as the viewmodel can outlive the activity(the context shouldn't referenced in a viewmodel).

Purpose of the code:

TL;DR: These changes are not needed and the TODO should just be removed

Inside the viewmodel the deckId is only used when saving the note(no need for a flow).
In the activity we don't need to do "something" in response to the deck id changing(the flow emitting), we only need the id in response to a user action: showing the dialog/the deck was changed. When those two situation happen we can just read the id from the viewmodel property(old code).

Also, I see that there's another todo in line 112: // TODO: Use did here . If it releates to the deck Id, it should probably be addressed here as well.

[criticalAY]

TBH I am ok removing TODO

[lukstbit]

Ok, I'm fine with it as well. Maybe also verify here the other TODO that I mentioned above if it's related.