Skip to content

Commit

Permalink
About section transparent logo (#3284)
Browse files Browse the repository at this point in the history
* changed anki-logo-thin.png to version with transparent background

* Revert "changed anki-logo-thin.png to version with transparent background"

This reverts commit 4c7e826.

* changed anki-logo-thin.png to version with transparent background

* added name to contributors as per contribution guidelines for first PR

* fixed contributors file rather than directly modifying about file
  • Loading branch information
isym444 authored Jul 20, 2024
1 parent 9d8782c commit 0b38ecd
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CONTRIBUTORS
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ RRomeroJr <117.rromero@gmail.com>
Xidorn Quan <me@upsuper.org>
Alexander Bocken <alexander@bocken.org>
James Elmore <email@jameselmore.org>
Ian Samir Yep Manzano <https://github.com/isym444>
David Culley <6276049+davidculley@users.noreply.github.com>
Rastislav Kish <rastislav.kish@protonmail.com>

Expand Down
1 change: 1 addition & 0 deletions qt/aqt/about.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ def on_dialog_destroyed() -> None:
"Marko Sisovic",
"Lucas Scharenbroch",
"Antoine Q.",
"Ian Samir Yep Manzano",
)
)

Expand Down
Binary file modified qt/aqt/data/web/imgs/anki-logo-thin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

1 comment on commit 0b38ecd

@dae
Copy link
Member

@dae dae commented on 0b38ecd Jul 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have reviewed this more carefully. This looks ugly when Anki is in night mode - the text would need a black outline or some other change so it's equally visible against a dark and light background.

Please sign in to comment.