Bold button is confused by font-weight span

[dae]

Paste the following in a field:

<span style="font-weight: 400;">test</span>

Select one of the characters inside and attempt to bold it. We end up with:

<b>te</b>s<b>t</b>

Original report: https://forums.ankiweb.net/t/applying-bold-inverts-selection/28641/3

[SeojinK1m]

Can I take this issue?

[dae]

Sure

[mmjang]

Can we change the threshold 400 to 700?

        const fontWeight = element.style.fontWeight;
        if (fontWeight === "bold" || Number(fontWeight) >= 400) {

https://github.com/ankitects/anki/blob/a2cd9ec34da353aa5f4d65002111ccd3966ab3a4/ts/editor/editor-toolbar/BoldButton.svelte#L28C30-L28C30

According this mdn doc, "bold" is mapped to font-weight: 700.

I did a little bit testing, and this change gives more reasonable behaviour.

From normal to bold:

From bold to normal:

Another way to fix this might be using getComputedStyle to get the actual weight of the element, and decide if it is considered "bold" with threshold 700.

[dae]

Thanks for digging into it! If the docs say 700, happy to go with a check for 700 - I've pushed this change to the main branch.