Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't return an error when optimizing if the current parameters are invalid #3498

Closed
user1823 opened this issue Oct 14, 2024 · 0 comments
Closed

Comments

@user1823
Copy link
Contributor

https://forums.ankiweb.net/t/fsrs-5-1d-scheduling-and-learning-steps/50242/73

Currently, if the parameters in the FSRS parameters field are invalid, Anki returns the following error on clicking Optimize.

Error: 500: The provided FSRS parameters are invalid. Leave them blank to use the default parameters.

In my opinion, Anki should simply replace the invalid parameters with the newly optimized ones and also skip RMSE comparison that is usually done to compare old and new parameters (because RMSE can't be calculated for the invalid parameters).

@L-M-Sherlock

L-M-Sherlock added a commit to L-M-Sherlock/anki that referenced this issue Oct 16, 2024
@dae dae closed this as completed in 6ff309e Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant