Fix Renaming note fields not updating custom browser appearance #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dae
reviewed
Jun 22, 2024
| @@ -575,6 +583,26 @@ impl Notetype { | |||
| self.templates[idx].config.a_format = a.template_to_string(); | |||
| } | |||
| } | |||
|
|
|||
| // Update browser templates, if they exist | |||
| for (idx, (q_browser_opt, a_browser_opt)) in parsed_browser.iter_mut().enumerate() { | |||
There was a problem hiding this comment.
Am I correct in assuming this is basically a copy+paste of the code above? If so, it would be a bit more elegant to factor the common code into a closure, then call the closure once for the main's enumerate(), and once for the browser templates.
There was a problem hiding this comment.
Good idea, I just moved the logic into 2 closures, although I'm not sure if q_update_fields and an_update_fields are the best names. Let me know what you think.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3244