Rename review limit #3320
Merged
Rename review limit #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dae
reviewed
Jul 26, 2024
This was referenced Jul 26, 2024
Merged
dae
added a commit
that referenced
this pull request
Aug 8, 2024
jeankhawand
pushed a commit
to jeankhawand/anki
that referenced
this pull request
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed
Maximum reviews/day—>Maximum cards/dayandNew cards ignore review limit—>New cards ignore maximum limit.As for tooltips, I think we should remove the text under 'deck-config-limit-interday-bound-by-reviews'. Instead, intraday learning cards should be mentioned as an exception to maximum card limit. I am not sure where do I put this or should I delete the aforementioned part.