Update type annotations to use | operator

[davidculley]

Updated Optional and Union type annotations to the | operator.

[davidculley]

This pull request fails because the | operator requires Python 3.10 or newer, but the Python version installed (using Pyenv) is 3.9.18.

I think we need to update these two files:

• https://github.com/ankitects/anki/blob/main/build/ninja_gen/src/python.rs
• https://github.com/ankitects/anki/blob/main/qt/bundle/pyoxidizer.bzl

The Python releases can be found here.

1. Do we want to update Python from 3.9 to something newer?
2. If yes, can anyone do this for me please?

[dae]

We cannot upgrade Python at this time, due to #3081. | annotations are supported on Python 3.9, provided the following line is found at the top of the file:

from __future__ import annotations

[dae]

While you are welcome to use CI for testing if you wish, you may find ./check on your local machine gives you a faster feedback cycle. I find it useful to put it into a git hook, so it happens automatically on push, and aborts the push if the check fails.

[davidculley]

I'm completely unfamiliar with the toolchain Anki uses and with Rust, but I'm slowly figuring things out. 🙂 Got the PR to pass! Thank you for your help!

Such a git hook sounds very useful. (I already use pre-commit.) Do you mind sharing the script?

[dae]

I have this at the top of pre-push:

set -e
if [ "$SKIP_CI" != "1" ]; then
    ./check
fi
exit

It's not perfect - it runs when I do things like try to push a tag deletion as well. But works well for the common case.