mypy: fix type checking error #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: Argument 1 to "_answerCard" of "Reviewer" has incompatible type "int"; expected "Literal[1, 2, 3, 4]" [arg-type]
dae
reviewed
Aug 22, 2024
qt/aqt/reviewer.py
Outdated
| def generate_default_answer_keys(): | ||
| for ease in aqt.mw.pm.default_answer_keys: | ||
| key = aqt.mw.pm.get_answer_key(ease) | ||
| if key: |
There was a problem hiding this comment.
Walrus operator would make this more concise
There was a problem hiding this comment.
Should key only be not None or does it also need to be different from the empty string?
In other words: I would like to change if key: to if key is not None:, provided this doesn't change its meaning.
There was a problem hiding this comment.
The user can enter an empty string in the preferences, so we also need to guard against that.
There was a problem hiding this comment.
Thank you for fixing the code. I wasn't sure about that.
to avoid nesting.
dae
reviewed
Aug 29, 2024
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have an easier time in my other pull requests, when figuring out which type errors were introduced by me and which already existed, I'm fixing some of the type errors on the current main branch.
This pull request fixes this mypy error:
The function
_answerCardwants only numbers 1, 2, 3 or 4 (that is, a variable of typeLiteral[1, 2, 3, 4]. But we're passing a variable of typeintwhich can hold many more numbers than these mentioned four.I'm basically just
inttoLiteral[1, 2, 3, 4](which by itself would already suffice)