Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports of decks with file paths using special URL characters #3377

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

themis-d
Copy link
Contributor

This fixes #3352 by escaping special characters in the file path selected by the user for importing a deck, ensuring that the path is interpreted correctly as a URL (i.e. "#" is converted to "%23") using the quote() function from 'urllib.parse'.

@dae
Copy link
Member

dae commented Aug 29, 2024

Thanks for this, Themis!

@dae dae merged commit 0f44796 into ankitects:main Aug 29, 2024
1 check passed
@dae
Copy link
Member

dae commented Aug 29, 2024

@lukstbit a heads up, in case AnkiDroid needs to make this change too

@themis-d themis-d deleted the fixup branch August 29, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash symbol in .apkg breaks import
2 participants