Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revert to backup option to file menu #3434

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

taylorobyen
Copy link
Contributor

@taylorobyen taylorobyen commented Sep 21, 2024

This addresses #3427

Load Backup button to File menu on the main window
image
When loading a backup the relative time it was taken is displayed
image

@dae
Copy link
Member

dae commented Sep 22, 2024

Sorry Taylor, I appear to have made a thinko. When I suggested mentioning the previous backup time, it was because I was assuming we'd be automatically selecting the most-recent backup. Giving the user a list of backups is more flexible, and it makes the time shown somewhat redundant. I was originally going to ask you to move the "x minutes ago" code into Rust so it can be shared across the clients, but since it's a bit redundant, the fastest way to get the PR over the line would be to change the message to show the backup filename instead of a relative time. Does that work for you?

@taylorobyen
Copy link
Contributor Author

No worries Damien, I've switched it to be filename as requested. 👍

Copy link
Member

@dae dae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(will put this through myself; was a pending suggestion that I forgot to send)

ftl/qt/qt-accel.ftl Outdated Show resolved Hide resolved
@dae
Copy link
Member

dae commented Sep 25, 2024

Thanks Taylor!

@dae dae merged commit df127b1 into ankitects:main Sep 25, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants