typeanswer: NFC fix & cleanup #3482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DiffNonCombining's new() used String where plain Vec is appropriate * get rid of normalize_typed for DiffTrait again by pulling code into DiffNonCombining's new() * two DiffNonCombining testcases
twwn
force-pushed
the
typeanswer-cleanup
branch
from
0b844f2
to
8fd15da
Compare
These things tend to happen :-) And I was the one that brought up the NFC point. Appreciate you addressing issues and tidying things up. Anki pins a specific nightly version so that the formatting is consistent - formatting is invoked with cargo/format as the working dir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry if this is getting annoying as my last PR was already the "final" cleanup, but this should really be it…
No functional changes:
new()usedStringwhere plainVecis appropriatenormalize_typedfor DiffTrait again by pulling code into DiffNonCombining'snew()Functional change
typeanswer.rsfor now. If it breaks the non-combining comparison for other languages, we can still re-revert only for it to NFKD later. (This time I'd skipnormalize_to_nfkd/text.rsand just go fornfkd()directly, it returning an iterator also allows more concise code.)(Curiously my local nightly
rustfmtnow wants to reformat other testcases in a way that breaks the repo check.)