Create a new kind of revlog entry for reschedule cards on change #3508
Conversation
| for e in group.into_iter() { | ||
| if e.button_chosen >= 1 { | ||
| last_reviewed_at = Some(e.id.as_secs()); | ||
| } | ||
| last_revlog_is_manual = e.review_kind == RevlogReviewKind::Manual; | ||
| last_revlog_is_rescheduled = e.review_kind == RevlogReviewKind::Rescheduled; |
There was a problem hiding this comment.
What about older cards that were rated in previous Anki versions. Should we be accepting either manual or rescheduled here?
There was a problem hiding this comment.
My concern is the user may feel confused if they set due date for a card and reschedule all cards, they will only see the first revlog entry generated by set due date.
There was a problem hiding this comment.
This only affects card rescheduling when saving deck options, yes? Won't an upgrading user with previous set due date use see quite different results when rescheduling now, compared to what they were getting previously? Is that intentional?
There was a problem hiding this comment.
This change aimed at reducing the collection bloat caused by a user experimenting with reschedule multiple times in a short period. But it didn't distinguish "Reschedule cards on change" and "Set Due Date". I think it's a problem, so my PR fix it intentionally.
L-M-Sherlock
deleted the
create-a-new-kind-of-revlog-entry-for-Reschedule-cards-on-change
branch
close #3357