Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/skip suspended cards in graphs context retrievability #3518

Conversation

L-M-Sherlock
Copy link
Contributor

@L-M-Sherlock L-M-Sherlock commented Oct 21, 2024

close #3517

image

@user1823
Copy link
Contributor

user1823 commented Oct 21, 2024

There still exists a minor discrepancy.

It is likely because the add-on counts all siblings, including the suspended ones. If you want, I can submit a PR in the add-on repo to correct this.

Edit:

@brishtibheja
Copy link
Contributor

It's not a good idea to do that here but not elsewhere in stats. Also, if you trust in the DSR values, you know some material of the suspended cards. That not being in total knowledge is weird.

I actually keep most of my cards (suspended) even after I've learned them to a very good level (for duplicate checking). Works for yomitan etc. If some users would want to look at total knowledge or other graphs with is:suspended cards excluded perhaps can add an option for them? Similar to what we have in "Card Counts".

@dae
Copy link
Member

dae commented Oct 26, 2024

First things first, let's make it consistent with the add-on. If you're proposing further changes to both, that's perhaps better discussed separately.

@dae dae merged commit 939cc5a into ankitects:main Oct 26, 2024
1 check passed
@L-M-Sherlock L-M-Sherlock deleted the Fix/skip-suspended-cards-in-GraphsContext-retrievability branch October 26, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy between add-on and native "Estimated total knowledge"
4 participants