Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add a toggle in the simulator to display time or review count #3523

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Feat/add a toggle in the simulator to display time or review count #3523

merged 2 commits into from
Oct 26, 2024

Conversation

L-M-Sherlock
Copy link
Contributor

@L-M-Sherlock L-M-Sherlock commented Oct 23, 2024 •
edited
Loading

Preview:

image

Misc:

  • replace raw strings with i18n strings
  • loosen config limits

@dae
Copy link
Member

dae commented Oct 26, 2024

A nice improvement - thanks as always Jarrett.

@dae dae merged commit eacd5bf into ankitects:main Oct 26, 2024
1 check passed
@dae
Copy link
Member

dae commented Oct 26, 2024

(and apologies, I forgot to remove the 'co-authored-by' tag that github adds when I merge main in)

@L-M-Sherlock L-M-Sherlock deleted the Feat/add-a-toggle-in-the-simulator-to-display-time-or-review-count branch October 26, 2024 10:02
@L-M-Sherlock
Copy link
Contributor Author

I don't mind. Reviewing the code also took your time. Thank you for your help all along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-M-Sherlock @dae