Fix/buried new cards shouldn't be counted in daily load #3530
Conversation
|
What if you exclude cards having |
Because it will be inconsistent with the helper add-on. For details, please see: |
|
But, in that case (memory states lost due to changing deck), excluding these cards from the daily load makes the calculation inaccurate. So, I would say that it is better to change the calculation in the helper add-on than making the calculation inaccurate in Anki too. |
|
Here is the related code: In the helper add-on, daily load and estimated total knowledge share the same query. |
|
If you think that changing the calculation in the add-on would be too difficult (because it is coupled with the other stats), just remove Daily Load from the add-on in 24.10+. Anki already has it and duplicating features is not necessary. |
|
Is that necessary, a very tiny percentage of users use FSRS Helper who'll also notice discrepancies like this. The add-on feature is probably useful to those who wouldn't update to 24.10 version any time soon. |
The add-on could know which version the user is running. If the version is greater or equal to 24.10, just hide daily load. If not, display it. |
|
Because the buried new cards shouldn't be included in any of the stats in this file, it might make sense to exclude those cards in the very beginning, i.e., just after This won't affect the other stats. But, it might slightly improve the performance and prevent similar bugs in the future. |
|
Further tweaks to this part of the code might be better done as part of #3379 |
L-M-Sherlock
deleted the
Fix/buried-new-cards-shouldn't-be-counted-in-daily-load
branch
ankitects#3530 (comment) Before ankitects@7ea573b, they were excluded anyway.
* Exclude new cards from Future Due stats #3530 (comment) Before 7ea573b, they were excluded anyway. * Update future_due.rs * Update comment * Minor simplification
fix #3529, open-spaced-repetition/fsrs4anki-helper#480
New cards don't have memory state, so I exclude them in that way. And it's consistent with FSRS helper.