Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy import option #3536

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

abdnh
Copy link
Collaborator

@abdnh abdnh commented Oct 27, 2024

Closes #3493

@dae
Copy link
Member

dae commented Oct 28, 2024

If a user has the legacy importer enabled and upgrades, isn't this going to leave them with it stuck on? Perhaps we should be making legacy_import_export() always return False as well, and then the add-on can override it?

@abdnh
Copy link
Collaborator Author

abdnh commented Oct 28, 2024

If a user has the legacy importer enabled and upgrades, isn't this going to leave them with it stuck on?

That crossed my mind, but thought maybe it's a rare case.

Perhaps we should be making legacy_import_export() always return False as well, and then the add-on can override it?

The add-on no longer uses the config option. It patches the new importing path instead: https://github.com/johnpincock/SpecialFields/pull/39/files

@dae dae merged commit 43d9b00 into ankitects:main Nov 5, 2024
1 check passed
@abdnh abdnh deleted the remove-legacy-import-option branch November 5, 2024 13:55
@Expertium
Copy link
Contributor

https://www.reddit.com/r/Anki/comments/1hfr5e5/no_more_legacy_importexport_handling_in_2411/

No more legacy import/export handling in 24.11?

I noticed this since I use u/Glutanimate's Export Deck to HTML and Print to PDF and it relies on the legacy export options. Had to downgrade.

image

@GithubAnon0000
Copy link

Seems like that user only needs the legacy import option because they use some addons that rely on that.

Wouldn't it be much better to update the addons (or choose alternatives if they exist) then to keep and maintain any legacy option in anki? Not sure if @glutanimate still updates those addons, though.

@abdnh
Copy link
Collaborator Author

abdnh commented Dec 17, 2024

Add-ons that need legacy handling can be fixed with minor changes (see the Special Fields add-on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacy importer option from GUI
4 participants