Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/inconsistent retrievability calculations between normal/filtered decks and display/sorting #3582

Conversation

L-M-Sherlock
Copy link
Contributor

source: https://forums.ankiweb.net/t/anki-24-10-release-candidate/51191/120?u=l.m.sherlock

This PR addresses two inconsistencies in retrievability calculations:

  1. Fixes the discrepancy in retrievability values between normal decks and filtered decks for the same card by using the original due date (odue) when card belongs to filtered deck.
  2. Fixes retrievability calculations between display strings and review sorting to ensure consistent behavior

Changes:

  • Modified due date handling to consider original due date (odue) when card belongs to filtered deck.
  • Removed unnecessary max(0) operations from due date calculations

These changes ensure that retrievability values are calculated consistently across all contexts where they are used.

@dae
Copy link
Member

dae commented Nov 17, 2024

Thanks Jarrett - the effort you put in to address not only issues directly inside FSRS but also in Anki's integration of it is greatly appreciated. :-)

@dae dae merged commit e992d6d into ankitects:main Nov 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants