Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced uniqid with Ramsey\Uuid\Uuid +uuid4() #196

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Replaced uniqid with Ramsey\Uuid\Uuid +uuid4() #196

merged 1 commit into from
Oct 1, 2019

Conversation

claudiunicolaa
Copy link
Contributor

@claudiunicolaa claudiunicolaa commented Oct 1, 2019 •
edited by ankitpokhrel
Loading

Fixes #140

@codecov
Copy link

codecov bot commented Oct 1, 2019 •
edited
Loading

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #196   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      335    335           
=======================================
  Files            19     19           
  Lines           907    907           
=======================================
  Hits            907    907
Impacted Files Coverage Δ Complexity Δ
src/Tus/Client.php 100% <100%> (ø) 65 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 680c382...e5a8c2d. Read the comment docs.

ankitpokhrel
ankitpokhrel approved these changes Oct 1, 2019
View reviewed changes
Copy link
Owner

@ankitpokhrel ankitpokhrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ankitpokhrel ankitpokhrel merged commit b2e4b83 into ankitpokhrel:master Oct 1, 2019
@ankitpokhrel ankitpokhrel modified the milestone: v1.1 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitpokhrel ankitpokhrel ankitpokhrel approved these changes

Assignees
No one assigned
Labels
client Tus Client improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UUID enhancement
2 participants
@claudiunicolaa @ankitpokhrel