Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newline in bin/tus causing extra output #238

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

stephank
Copy link

This was causing additional output from commands even when passing the --quiet flag. Any output from commands used as a cronjob causes cron to notify the administrator via email.

To test, run vendor/bin/tus tus:expired -q. Before, it'd print an empty line. After, there is no output at all. (Alternatively, run vendor/bin/tus without any arguments to get the usage message, and notice the difference in newlines above the message.)

This was causing additional output from commands even when passing the `--quiet` flag. Any output from commands used as a cronjob causes cron to notify the administrator via email.
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #238 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #238   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       351       351           
===========================================
  Files             20        20           
  Lines            936       936           
===========================================
  Hits             936       936           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26df82...14e5ae2. Read the comment docs.

@ankitpokhrel ankitpokhrel merged commit a104f38 into ankitpokhrel:master Feb 17, 2020
@ankitpokhrel
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants