Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align metadata extraction with protocol #379

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Conversation

ankitpokhrel
Copy link
Owner

This PR make some changes on metadata extraction to align with the protocol.

  • The value MAY be empty. In these cases, the space, which would normally separate the key and the value, MAY be left out.
  • Even though the protocol doesn't say anything about empty space after comma and key, the official implementation seems to trim extra spaces.

Ref: https://tus.io/protocols/resumable-upload.html#upload-metadata

Fixes #378

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #379 (f9fd90c) into main (c6d98d6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #379   +/-   ##
=========================================
  Coverage     99.58%   99.58%           
  Complexity      360      360           
=========================================
  Files            20       20           
  Lines           964      968    +4     
=========================================
+ Hits            960      964    +4     
  Misses            4        4           
Impacted Files Coverage Δ
src/Request.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d98d6...f9fd90c. Read the comment docs.

@ankitpokhrel ankitpokhrel marked this pull request as ready for review February 3, 2022 21:47
@ankitpokhrel ankitpokhrel merged commit c5f66c0 into main Feb 4, 2022
@ankitpokhrel ankitpokhrel deleted the patch/issue-378 branch February 4, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem with ios client (TUSKit), incorrect Upload-Metadata is being sent
1 participant