Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the search condition statement #81

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Fixed the search condition statement #81

merged 1 commit into from
Aug 26, 2021

Conversation

justin-duncan
Copy link
Contributor

@justin-duncan justin-duncan commented Aug 25, 2021

Description

As it stands, the behavior is that if the search obj is absent, it will pass. However, if any value is given, including false, { searchOptions }, etc... it will not load the libraries.

Solved the condition related to importing the fuse.js and search functionalities from working due to incorrect usage of the Boolean().
See Documentation Description.

Solution

Re-write the condition to be options !== 'false', since as dictated, any value should load these libraries unless explicitly given a false value.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Other (if so, then explain below briefly)

Solved the condition related to importing the fuse.js and search functionalities from working due to incorrect usage of the Boolean().
@ankitskvmdam
Copy link
Owner

Thanks for the PR. I will take a look and let you know.

@ankitskvmdam ankitskvmdam merged commit 2ab31e5 into ankitskvmdam:master Aug 26, 2021
This was referenced Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants