-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the search condition statement #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solved the condition related to importing the fuse.js and search functionalities from working due to incorrect usage of the Boolean().
Thanks for the PR. I will take a look and let you know. |
This was referenced Aug 27, 2021
This was referenced Feb 11, 2022
This was referenced Feb 21, 2022
This was referenced Jun 13, 2022
This was referenced Jun 29, 2022
This was referenced Jul 4, 2022
This was referenced Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it stands, the behavior is that if the search obj is absent, it will pass. However, if any value is given, including false, { searchOptions }, etc... it will not load the libraries.
Solved the condition related to importing the fuse.js and search functionalities from working due to incorrect usage of the Boolean().
See Documentation Description.
Solution
Re-write the condition to be options !== 'false', since as dictated, any value should load these libraries unless explicitly given a false value.
Type of change