Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really fix building on windows #5

Closed
wants to merge 1 commit into from
Closed

Really fix building on windows #5

wants to merge 1 commit into from

Conversation

karllinden
Copy link
Contributor

@karllinden karllinden commented Jul 11, 2017

It seems not all my changes where recorded in PR #4, which is strange. This PR should introduce the remaining fixes as promised in #4.

@ankurk91
Copy link
Owner

ankurk91 commented Jul 11, 2017

This issue is specific to Windows OS.
This can be easily fix by -

#cd DRIVE:\path\to\project
cd D:\projects\your-project
npm run dev

Notice the the capital D , taken from

Also renaming the .vue file may be breaking change for some users.

// some users may be importing the package like this
import flatPickr from 'vue-flatpickr-component/src/flatPickr.vue';

You can import from dist folder in order to fix windows build

import flatPickr from 'vue-flatpickr-component/dist/vue-flatpickr.min.js';

I may think renaming the .vue in next major release.

Thanks for understanding.

@ankurk91 ankurk91 closed this Jul 11, 2017
@karllinden karllinden deleted the feature/fix-windows-build branch July 11, 2017 06:56
@karllinden
Copy link
Contributor Author

I understand. Do you want me to file an issue on this, for tracking the feature request?

@ankurk91
Copy link
Owner

No, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants