Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(twitter-icon): updated twitter icon and fixed unrelated changes #860

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Namit2111
Copy link
Contributor

Related Issue

Closes: #837
Closes: #853

Description of Changes

  • [ ✔] My code adheres to the established style guidelines of this project.
  • [ ✔] I have conducted a self-review of my code.
  • [✔ ] I have included comments in areas that may be difficult to understand.
  • [✔ ] I have made corresponding updates to the project documentation.
  • [✔ ] My changes have not introduced any new warnings.

Copy link

vercel bot commented Oct 5, 2024

@Namit2111 is attempting to deploy a commit to the anmode's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 5, 2024

Thank you, @Namit2111, for creating this pull request and contributing to GitHub-ReadMe!
Our review team will thoroughly review the pull request and will reach out to you soon!
Please make sure you have marked all the completed tasks as done.
We appreciate your patience and contribution!

.gitattributes Show resolved Hide resolved
@Sanchitbajaj02
Copy link
Collaborator

Hi @Namit2111
How is your PR fixes the issue #837 ? Can you give a brief about it?

@Namit2111
Copy link
Contributor Author

Hi @Namit2111 How is your PR fixes the issue #837 ? Can you give a brief about it?

The solution sets LF line endings by default for all systems using .gitattributes, preventing automatic conversions caused by OS differences.

The automatic conversion of files was adding files every time in the git history.

@Sanchitbajaj02 Sanchitbajaj02 added bug Something isn't working level1 hacktoberfest This is level for the hacktoberfest 2023 hacktoberfest-accepted This is level for the hacktoberfest 2023 gssoc-ext labels Oct 10, 2024
Copy link
Collaborator

@Sanchitbajaj02 Sanchitbajaj02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sanchitbajaj02 Sanchitbajaj02 merged commit feaf836 into anmode:develop Oct 11, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext hacktoberfest This is level for the hacktoberfest 2023 hacktoberfest-accepted This is level for the hacktoberfest 2023 level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Twitter Symbol to X in footer section 🐞 [BUG] - Unrelated files changes --PWA thing
2 participants