Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add NAF code sections #15

Merged
merged 2 commits into from
May 31, 2022
Merged

feat: add NAF code sections #15

merged 2 commits into from
May 31, 2022

Conversation

HAEKADI
Copy link
Contributor

@HAEKADI HAEKADI commented May 25, 2022 •
edited
Loading

@HAEKADI HAEKADI self-assigned this May 25, 2022
@HAEKADI HAEKADI mentioned this pull request May 26, 2022
Merged
@HAEKADI
Copy link
Contributor Author

HAEKADI commented May 26, 2022

@geoffreyaldebert I could not import the sections-codes-NAF.json from the labels folder into Airflow tmp path to use in the notebook, so I ended up creating the json object in the notebook itself.
Do you think we should put the json file in Minio to access it or is there a better way to import it into Airflow tmp path ?

@geoffreyaldebert geoffreyaldebert merged commit 04f57c2 into main May 31, 2022
@geoffreyaldebert geoffreyaldebert deleted the section-NAF branch June 1, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierJp XavierJp XavierJp approved these changes

@geoffreyaldebert geoffreyaldebert geoffreyaldebert approved these changes

Assignees

@HAEKADI HAEKADI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HAEKADI @geoffreyaldebert @XavierJp